Fix exception in g_to_c mapping #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reece
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Thanks Brendan! This looks good with some very small change requests.
conftest.py has most of the fixtures that you define in test_764.py. Would you please use those instead? I think it should be sufficient to remove the hdp and am37 fixtures, and renaming hp to parser.
You'll need to define your own vm for now. Although, for bonus points, you could move it to conftest.
You might very well have modeled this on existing tests, but I've recently uncovered challenges with the current layout. See #760 and #761 for details.
The path forward is to consolidate fixtures in conftest.py.
Thanks!
| @@ -268,6 +268,7 @@ def g_to_c(self, var_g, tx_ac, alt_aln_method=hgvs.global_config.mapping.alt_aln | |||
| edit_c.type == "ins" | |||
| and pos_c.start.offset == 0 | |||
| and pos_c.end.offset == 0 | |||
| and pos_c.start.datum == pos_c.end.datum | |||
|
Thanks @reece. Using the |
reece
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764.